This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Give vitess a chance to enforce connection timeouts if we've been waiting for a row for longer #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 9, 2019 18:26
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
juanjux
changed the title
creachadair
reviewed
Aug 9, 2019
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
creachadair
reviewed
Aug 9, 2019
…usage Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
erizocosmico
suggested changes
Aug 12, 2019
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
erizocosmico
suggested changes
Aug 12, 2019
erizocosmico
approved these changes
Aug 12, 2019
creachadair
reviewed
Aug 12, 2019
|
|
||
| rowchan := make(chan sql.Row) | ||
| errchan := make(chan error) | ||
| quit := make(chan struct{}) |
There was a problem hiding this comment.
[optional] You could put defer close(quit) here, instead of calling it in multiple places below. As far as I can see, anytime this function returns, you'd want quit closed anyway.
There was a problem hiding this comment.
I prefer to make it explicit so the code reader can see where we are actively signaling the goroutine.
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Refactor rowloop select Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
ajnavarro
approved these changes
Aug 14, 2019
|
@ajnavarro dont merge, maybe my next PR will make this unnecesary. |
lwsanty
added a commit
to src-d/regression-gitbase
that referenced
this pull request
Aug 15, 2019
Signed-off-by: lwsanty <lwsanty@gmail.com>
|
Closing, definitely superseeded by the next PR that improves also this part and fixes a bug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #799
Related issue: https://github.com/src-d/gitbase-spark-connector-enterprise/issues/81
This PR abort further
rowIterator.Next()calls if the time waiting for a single row is bigger than the configuredConnReadTimeoutthus giving a change to Vitess to call theHandler.CloseConnection()callback when it detects the timeout. It does it by running the calls to the iterator on a looped goroutine with anTimerwhich checks that we didn't exceed the timeout.This doesn't fix issue #800 which implies detecting a closed connection before the timeout expires and killing the associated queries, but serves to somewhat workaround it by configuring a timeout.